New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document or fix linting on shallow clones #7

Closed
marionebl opened this Issue Jul 7, 2016 · 3 comments

Comments

2 participants
@marionebl
Owner

marionebl commented Jul 7, 2016

Shallow cloned repository yield errors via git-raw-commits. conventional-changelog-lint should either document how to circumvent these limitations or support commit listing on shallow clones, too.

see #6

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Jul 7, 2016

Here's a workaround for TravisCI (which does shallow clones): #6 (comment)

kumar303 commented Jul 7, 2016

Here's a workaround for TravisCI (which does shallow clones): #6 (comment)

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Jul 7, 2016

My workaround had an issue with tag commits since those result in a detached head. My current workaround is to do this in my before_install TravisCI yaml section:

git remote set-branches origin master && git fetch
git checkout master
# Go back to the original commit that TravisCI checked out:
git checkout -

I'm not sure exactly why but this makes the master branch visible to the linter.

kumar303 commented Jul 7, 2016

My workaround had an issue with tag commits since those result in a detached head. My current workaround is to do this in my before_install TravisCI yaml section:

git remote set-branches origin master && git fetch
git checkout master
# Go back to the original commit that TravisCI checked out:
git checkout -

I'm not sure exactly why but this makes the master branch visible to the linter.

@marionebl

This comment has been minimized.

Show comment
Hide comment
@marionebl

marionebl Mar 12, 2017

Owner

After chewing around on this for quite a while I'll go with the following approach:

  1. There is no way to get the git log messages from a shallow clone
  2. Document the need to pull in the full history for shallow clones. Provide TravisCI snippet.
  3. Detect shallow clones when running getMessages and print a warning throw with a link to said documentation
Owner

marionebl commented Mar 12, 2017

After chewing around on this for quite a while I'll go with the following approach:

  1. There is no way to get the git log messages from a shallow clone
  2. Document the need to pull in the full history for shallow clones. Provide TravisCI snippet.
  3. Detect shallow clones when running getMessages and print a warning throw with a link to said documentation

marionebl added a commit that referenced this issue Apr 8, 2017

@marionebl marionebl closed this in 8c354c5 May 1, 2017

marionebl added a commit that referenced this issue Jul 7, 2017

chore(release): v2.0.0
<a name="2.0.0"></a>
# [2.0.0](v1.1.9...v2.0.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this issue Jul 7, 2017

chore(release): v2.1.0
<a name="2.1.0"></a>
# [2.1.0](v1.1.9...v2.1.0) (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this issue Jul 7, 2017

fix: throw when detecting a shallow clone
* fix: warn about shallow clones

* docs: help with shallow clone troubleshooting

* closes #7
* closes #12

* test: simplify repo setup and teardown

marionebl added a commit that referenced this issue Jul 7, 2017

chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this issue Jul 7, 2017

chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this issue Jul 10, 2017

fix: throw when detecting a shallow clone
* fix: warn about shallow clones

* docs: help with shallow clone troubleshooting

* closes #7
* closes #12

* test: simplify repo setup and teardown

marionebl added a commit that referenced this issue Jul 10, 2017

chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this issue Jul 10, 2017

chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this issue Jul 10, 2017

fix: throw when detecting a shallow clone
* fix: warn about shallow clones

* docs: help with shallow clone troubleshooting

* closes #7
* closes #12

* test: simplify repo setup and teardown

marionebl added a commit that referenced this issue Jul 10, 2017

chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this issue Jul 10, 2017

chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))

marionebl added a commit that referenced this issue Jul 11, 2017

fix: throw when detecting a shallow clone
* fix: warn about shallow clones

* docs: help with shallow clone troubleshooting

* closes #7
* closes #12

* test: simplify repo setup and teardown

marionebl added a commit that referenced this issue Jul 11, 2017

chore(release): v2.0.0 <a name="2.0.0"></a> # [2.0.0](v1.1.9...v2.0.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)

marionebl added a commit that referenced this issue Jul 11, 2017

chore(release): v2.1.0 <a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0)…
… (2017-07-07)

### Bug Fixes

* prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427))
* rebuff rules ([#34](#34)) ([702a2f7](702a2f7))
* throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12)
* update to latest angular config ([b1f3606](b1f3606))

### Features

* ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment