Conflict between Marionette and Backbone.stickit #269

Closed
kevindente opened this Issue Oct 4, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@kevindente
Contributor

kevindente commented Oct 4, 2012

The Backbone.stickit data binding library is configured by defining a "bindings" property on the view. Unfortunately, this conflicts with the .bindings property created by Marionette.

I've worked around it for now by using the overload of stickit that lets you pass in a binding configuration as a parameter instead of reading it from the view property. But it would be nice if they could co-exist more nicely.

@derickbailey

This comment has been minimized.

Show comment
Hide comment
@derickbailey

derickbailey Oct 5, 2012

Member

+1

i'm not surprised this happened - it was just a matter of time, really. i'll see if i can get this figured out for the v0.11 release

Member

derickbailey commented Oct 5, 2012

+1

i'm not surprised this happened - it was just a matter of time, really. i'll see if i can get this figured out for the v0.11 release

@delambo delambo referenced this issue in NYTimes/backbone.stickit Oct 6, 2012

Closed

bindings seem to be un-sticking #12

@derickbailey

This comment has been minimized.

Show comment
Hide comment
@derickbailey

derickbailey Oct 6, 2012

Member

I'm having a hard time finding anything that uses a bindings setting in Marionette. am I looking for the wrong configuration / name?

Member

derickbailey commented Oct 6, 2012

I'm having a hard time finding anything that uses a bindings setting in Marionette. am I looking for the wrong configuration / name?

@derickbailey

This comment has been minimized.

Show comment
Hide comment
@derickbailey

derickbailey Oct 6, 2012

Member

I added Backbone.StickIt to my test suite for Marionette, in both the dev and master branch, and I don't see any conflicts. you sure this is a conflict with Marionette?

Member

derickbailey commented Oct 6, 2012

I added Backbone.StickIt to my test suite for Marionette, in both the dev and master branch, and I don't see any conflicts. you sure this is a conflict with Marionette?

@kevindente

This comment has been minimized.

Show comment
Hide comment
@kevindente

kevindente Oct 6, 2012

Contributor

It's actually with BindTo (I'm still on 0.9.3). In the bindTo function, "this.bindings.push". Maybe with the BindTo extraction this isn't a problem any more.

Contributor

kevindente commented Oct 6, 2012

It's actually with BindTo (I'm still on 0.9.3). In the bindTo function, "this.bindings.push". Maybe with the BindTo extraction this isn't a problem any more.

@jsoverson

This comment has been minimized.

Show comment
Hide comment
@jsoverson

jsoverson Oct 6, 2012

Member

Yeah, this is no longer an issue since BindTo was renamed and refactored to EventBinder. Bindings are stored in this._eventBindings now.

Member

jsoverson commented Oct 6, 2012

Yeah, this is no longer an issue since BindTo was renamed and refactored to EventBinder. Bindings are stored in this._eventBindings now.

@jsoverson jsoverson closed this Oct 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment