Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AMD version needlessly requiring jQuery (not a hard dependency) #531

Closed
OliverJAsh opened this Issue Mar 24, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

OliverJAsh commented Mar 24, 2013

The AMD version of Marionette requires jQuery, however this is not a hard dependency of Backbone. Backbone does not require jQuery, rather it just expects something of the type in the root context..

@derickbailey, would you be considering to take out this require? You already have Marionette.$ = Backbone.$ so the required $ is not actually being used anywhere by the looks of it.

Owner

derickbailey commented Mar 24, 2013

i dropped the jquery dependency from the package.config... taking it out of the amd build is probably smart, too, since we're now pulling out of Backbone.$

@derickbailey derickbailey reopened this Mar 24, 2013

Owner

derickbailey commented Mar 24, 2013

pulled the requirement of jQuery out of the AMD version, too. v1.0.1 has this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment