Move View specific functionality to view #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I like two things about this: I actually expect, that slowly going through some of these remaining shared methods will help us learn something about Marionette. As a sidenote, I was going to submit the massive PR w/ mixins, but I prefer this approach where we pluck a couple researched methods at a time. |
And then mix it in to the CompositeView Erring on the side of best View organization and less duplication, without breaking the deprecated CompositeView
paulfalgout
force-pushed
the
more-view-cleanup
branch
from
ab0d96b
to
3d7d197
Compare
|
obvious win. |
jasonLaster
added a commit
that referenced
this pull request
Dec 4, 2015
Move View specific functionality to view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2841
Seems like there are some very View specific things that are in the shared to support
CompositeViewThis moves all of that to theViewand then to avoid further duplication, mixes in the methods fromViewintoCompositeView