Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable chart-update #57

Open
Joelius300 opened this issue Dec 5, 2019 · 0 comments
Open

Customizable chart-update #57

Joelius300 opened this issue Dec 5, 2019 · 0 comments
Labels
enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there good first issue Good for newcomers
Milestone

Comments

@Joelius300
Copy link
Contributor

Joelius300 commented Dec 5, 2019

Describe the feature request

If I wanted to change how long it takes for the chart-update to render, I cannot do that because it's hardcoded without options in the ts-file (here).

Which charts does this feature request apply to?

All charts

Describe the solution you'd like

I'd like to be able to call Update on the chart-components with some additional, optional parameters like the duration, if the update should be lazy (can be interrupted) and which easing style. These should be optional parameters so

  1. you don't have to supply them
  2. you can only supply one or two if you want
  3. you can see the default values
  4. backwards-compatibility

However, since we'll have to implement a new string-enum, we won't be able to do it without an overload because an instance of that string-enum won't be a compile-time constant but that's not an issue.

These options are described here.

Describe alternatives you've considered

Change the js/ts on your own and link it statically but that's not desirable.

Additional context

Here are the easing options and some more information we might need.

@Joelius300 Joelius300 added enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there labels Dec 5, 2019
@Joelius300 Joelius300 added this to the Backlog milestone Apr 9, 2020
@Joelius300 Joelius300 added the good first issue Good for newcomers label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant