Skip to content

feat: add env support in mcp server config #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

feat: add env support in mcp server config #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import (

// MCPServerConfig represents configuration for an MCP server
type MCPServerConfig struct {
Command string `json:"command,omitempty"`
Args []string `json:"args,omitempty"`
URL string `json:"url,omitempty"`
Headers []string `json:"headers,omitempty"`
AllowedTools []string `json:"allowedTools,omitempty"`
ExcludedTools []string `json:"excludedTools,omitempty"`
Command string `json:"command,omitempty"`
Args []string `json:"args,omitempty"`
Env map[string]any `json:"env,omitempty"`
URL string `json:"url,omitempty"`
Headers []string `json:"headers,omitempty"`
AllowedTools []string `json:"allowedTools,omitempty"`
ExcludedTools []string `json:"excludedTools,omitempty"`
}

// Config represents the application configuration
Expand Down
7 changes: 6 additions & 1 deletion internal/tools/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,12 @@ func (m *MCPToolManager) shouldExcludeTool(toolName string, serverConfig config.
func (m *MCPToolManager) createMCPClient(ctx context.Context, serverName string, serverConfig config.MCPServerConfig) (client.MCPClient, error) {
if serverConfig.Command != "" {
// STDIO client
return client.NewStdioMCPClient(serverConfig.Command, nil, serverConfig.Args...)
env := make([]string, 0, len(serverConfig.Env))
for k, v := range serverConfig.Env {
env = append(env, fmt.Sprintf("%s=%v", k, v))
}

return client.NewStdioMCPClient(serverConfig.Command, env, serverConfig.Args...)
} else if serverConfig.URL != "" {
// SSE client
sseClient, err := client.NewSSEMCPClient(serverConfig.URL)
Expand Down