add context manager

[desaleo]

proposal: add a context manager for lighter syntax and guarantee connection closure so instead of this:

from factorio_rcon import RCONClient

client = RCONClient("127.0.0.1", 12345, "mypassword")
response = client.send_command("/help")
client.close()

we can simply do:

from factorio_rcon import RCONClient

with RCONClient("127.0.0.1", 12345, "mypassword") as client:
    response = client.send_command("/help")

also for async clients:

from factorio_rcon import AsyncRCONClient

async with AsyncRCONClient("127.0.0.1", 12345, "mypassword") as client:
    response = await client.send_command("/help")

I have to admit that this is my first pull request and I may be doing things wrong, I also haven't found a suitable docstring to these methods.

(also this probably need it's own ticket/pull request but you're using assert in prod in both receive_exactly methods instead of raising RCONNotConnected)

[mark9064]

Looks great, I'm totally onboard with the idea API-wise.

The class docstrings / readme should probably mention that they can be used as context managers. But I'm happy to merge this and then add that after this PR :)

I don't specify anywhere in the project so this is on me: this project uses black for code formatting so could you stick it through that (I should really have CI for this...)

PS You're right on the asserts: those methods aren't meant to be called outside (and so aren't documented), and inside all usages are safe so the assertion is mainly for type checking reasons

Edit: I just saw your comment about docstrings, for context manager dunders no docstring is the way to go (as they'll never be seen) so it's already complete w.r.t that

[desaleo]

All requested changes done (if I haven't missed any).

[mark9064]

Hey are you still working on this? It'd be nice to land these changes :)

[desaleo]

i'm sorry i've been really busy lately, i work on it as soon as i can

[mark9064]

Don't worry there's no rush at all! Just wanted to see if you were still interested in doing this, so take a look at this whenever you want

[desaleo]

sorry for the long radio silence, this should be good now

[mark9064]

Looks great!