Make monkey-patching of the language optional #40

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@gdb
Collaborator
gdb commented Feb 13, 2013

In my application, we don't allow monkey-patching of the language. We've found that various libraries tend to monkey-patch in incompatible ways, and it's very hard to excise dependence on a particular monkey-patch once it's in the codebase.

I've made monkey-patching opt-in rather than opt-out, but can change that around if necessary.

@markbates
Owner

If I'm correct, this turns off monkey patching by default, correct? If so, I would need this patch to be inverted. A lot of people use this feature, and it would pull the rug out from underneath them.

@gdb
Collaborator
gdb commented Jun 19, 2013

Yep, that's right (wasn't sure if opt-out would be necessary, per my note above).

Behavior inverted. The interface is that you load 'configatron/core' to not get the monkey-patches (similar to how sinatra and state_machine do it, for instance).

@markbates
Owner

This caused a lot of merge conflicts with the laster master version. Can you please resolve in your branch and then re-open the PR? Thanks.

@markbates markbates closed this Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment