From 21f640e96ea5bbc6ccdc9049679c3be95bafdaab Mon Sep 17 00:00:00 2001
From: Andrew McClenaghan <andrew.mcclenaghan@gmail.com>
Date: Tue, 2 May 2023 12:07:26 +1000
Subject: [PATCH] fix: ts errors in tests

---
 packages/lib/src/Publisher.test.ts | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/packages/lib/src/Publisher.test.ts b/packages/lib/src/Publisher.test.ts
index dbfd84d0..4f3183f1 100644
--- a/packages/lib/src/Publisher.test.ts
+++ b/packages/lib/src/Publisher.test.ts
@@ -212,7 +212,7 @@ const markdownTestCases: MarkdownFile[] = [
 
 class TestMermaidRenderer implements MermaidRenderer {
 	async captureMermaidCharts(
-		charts: ChartData[]
+		_charts: ChartData[]
 	): Promise<Map<string, Buffer>> {
 		const capturedCharts = new Map<string, Buffer>();
 		return capturedCharts;
@@ -226,8 +226,8 @@ class InMemoryAdaptor implements LoaderAdaptor {
 		this.inMemoryFiles = inMemoryFiles;
 	}
 	async updateMarkdownValues(
-		absoluteFilePath: string,
-		values: Partial<ConfluencePerPageAllValues>
+		_absoluteFilePath: string,
+		_values: Partial<ConfluencePerPageAllValues>
 	): Promise<void> {}
 
 	async loadMarkdownFile(absoluteFilePath: string): Promise<MarkdownFile> {
@@ -241,8 +241,8 @@ class InMemoryAdaptor implements LoaderAdaptor {
 	}
 
 	async readBinary(
-		path: string,
-		referencedFromFilePath: string
+		_path: string,
+		_referencedFromFilePath: string
 	): Promise<false | BinaryFile> {
 		throw new Error("Method not implemented.");
 	}
@@ -271,12 +271,16 @@ test("Upload to Confluence", async () => {
 		searchParams
 	);
 
-	settings.confluenceParentId = contentByTitle.results[0].id;
+	const pageResult = contentByTitle.results[0];
+	if (!pageResult) {
+		throw new Error("Missing Parent Page");
+	}
+	settings.confluenceParentId = pageResult.id;
 
 	const settingLoaders = [
 		new EnvironmentVariableSettingsLoader(),
 		new StaticSettingsLoader({
-			confluenceParentId: contentByTitle.results[0].id,
+			confluenceParentId: pageResult.id,
 		}),
 		new DefaultSettingsLoader(),
 	];