Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message: token type cannot be found #1005

Merged
merged 1 commit into from Dec 18, 2018

Conversation

@KostyaTretyak
Copy link
Contributor

commented Jan 7, 2018

It seems to me that such a message will be appropriate. If I did not write very English, the wishes for corrections are accepted.

@joshbruce

This comment has been minimized.

Copy link
Member

commented Jan 7, 2018

@KostyaTretyak: Can you give me an example of a type? I don't know enough about marked to knwo what we mean by "token" or "type".

@KostyaTretyak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2018

Forgive me, but you should not maintain this project if you do not know what a token is and what a type of token is. By the way, it is elementary looking in the project.

@joshbruce

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

@KostyaTretyak: Forgiven. I will ask you forgive me as well, if this seems harsh or offbase.

I help maintain enough projects to know that they all use language differently. What makes language difficult is that we have to encode and decode messages, which comes from understanding the language. I'm only asking for courtesy and assistance from someone who knows the language of the community and the library because I don't; in the time it took to write your reply - you probably could have answered the question (thereby, helping me become smarter).

To put it bluntly, I don't know if I can help with the English question of this PR because I'm missing the word replacement possibilities in the submission...but, I would like to help, as I'm pretty good with language and user experience.

Also, to be fair, I don't "maintain" the project - I coordinate and publish the exceptional efforts of the maintainers such as yourself, @UziTech, @Feder1co5oave, and so on. If you believe I am doing a poor job or am underqualified, please let me know and I will begin the stepping away protocol eluded to in #956.

Again, just asking for help in increasing my knowledge and understanding by interacting with someone who knows - I'm more of a people person in that regard.

If there was a test demonstrating the expectation and result, the answer would be obvious without me (or another developer) needing to know how marked works (to be fair, I don't know if writing a test is possible for this PR). That's what our tests offer our users - documentation on usage and expectation without needing a high-level of knowledge about the marked lib.

@Feder1co5oave

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2018

This seems pointless at the current situation, but might be useful once we make marked a bit more easily extensible

@joshbruce joshbruce added this to the 0.6.0 - Improve developer experience milestone Jan 8, 2018

@joshbruce

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

@Feder1co5oave: Agreed. Flagged for 0.6.0.

@joshbruce joshbruce modified the milestones: 0.6.0 - Improve developer experience, v1.x - All the nope release Apr 4, 2018

@styfle styfle changed the title We are talking to the developer that this type of token can not be found Add message: token type cannot be found May 14, 2018

lib/marked.js Show resolved Hide resolved
@styfle

styfle approved these changes Dec 17, 2018

@styfle styfle merged commit 9a522d6 into markedjs:master Dec 18, 2018

1 check passed

WIP ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.