Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove failing test for now #1098

Merged
merged 2 commits into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@UziTech
Copy link
Member

commented Feb 28, 2018

Marked version: 2ef9bbf

Description

Makes travis tests pass so we can see if PRs are actually failing

I just added .bak to the failing test so we can easily add it back once it is passing.

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • cm_autolinks is the only failing test (remove once CI is in place and all tests pass).
  • All lint checks pass (remove once CI is in place).
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech requested review from styfle and joshbruce Feb 28, 2018

@styfle

styfle approved these changes Feb 28, 2018

Copy link
Member

left a comment

Good idea. We can't have the CI crying wolf all the time or else no one will look at it. Approved 👍

@joshbruce

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

Nice! Can you remove the two committer checkboxes as well?? I mean, two birds, one stone. 😊

@joshbruce

This comment has been minimized.

Copy link
Member

commented Feb 28, 2018

We should probably also create an issue...wait, I think I already did that... #1092

@joshbruce
Copy link
Member

left a comment

See comments.

@joshbruce joshbruce merged commit 003764b into markedjs:master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@UziTech UziTech deleted the UziTech:remove-failing-test branch Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.