Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix `breaks` option description #1381

Merged
merged 1 commit into from Nov 28, 2018

Conversation

@UziTech
Copy link
Member

commented Nov 27, 2018

Fix the description for the "breaks" option

Marked version: master

Markdown flavor: Docs

Description

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@styfle

styfle approved these changes Nov 28, 2018

Copy link
Member

left a comment

Funny, that's what I thought it did but when I looked at the docs it seemed pretty specific.

The soft/hard break terminology is confusing 😕

Glad we got some consensus on this and it was simply the docs being wrong 😄

@joshbruce
Copy link
Member

left a comment

With Steve. Thanks!

@styfle styfle merged commit bf973d2 into markedjs:master Nov 28, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@UziTech UziTech deleted the UziTech:breaks-option branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.