Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make autolinks case insensitive #1384

Merged
merged 3 commits into from Dec 6, 2018

Conversation

@UziTech
Copy link
Member

commented Dec 5, 2018

Marked version: master

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

Make urls case insensitive

implements #1350 (comment)

marked("hTtP://fOo.CoM");
// <p><a href=\"hTtP://fOo.CoM\">hTtP://fOo.CoM</a></p>

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
test/specs/marked/marked.json Outdated Show resolved Hide resolved
test/specs/marked/marked.json Outdated Show resolved Hide resolved
@styfle

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

/cc @roygold7 since PR 1350 was started but didn't finish.

I want to make sure Roy is aware of this PR and that the reason for the new PR is no movement on the old PR.

I don't want to end up in this scenario.

styfle and others added some commits Dec 5, 2018

Update example number
Co-Authored-By: UziTech <tony@brix.ninja>
Update example number
Co-Authored-By: UziTech <tony@brix.ninja>
@roygold7

This comment has been minimized.

Copy link

commented Dec 5, 2018

@styfle I appreciate the comment but I'd be just as happy if the issue was resolved in a different PR. I'm not looking for credit.

@styfle styfle referenced this pull request Dec 6, 2018

@styfle styfle requested review from davisjam and joshbruce Dec 6, 2018

@davisjam

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

LGTM. This should not have a ReDoS impact.

@styfle styfle changed the title Make links case insensitive Make autolinks case insensitive Dec 6, 2018

@styfle styfle merged commit 06297df into markedjs:master Dec 6, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@UziTech UziTech deleted the UziTech:url-case-insensitive branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.