Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockquote paragraph continuation #1394

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@mccraveiro
Copy link
Contributor

commented Dec 19, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

> foo
    - bar

Expectation

<blockquote>
<p>foo
- bar</p>
</blockquote>

Result

<blockquote>
<p>foo</p>
<pre><code>- bar</code></pre></blockquote>

What was attempted

Fix blockquote paragraph continuation by limiting whitespaces before list item

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@UziTech

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

what is the input you are testing for the expected and actual output?

@mccraveiro

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

@UziTech I've updated the description with the actual input. Sorry :)

@UziTech
Copy link
Member

left a comment

Keep up the good work

@styfle

styfle approved these changes Dec 20, 2018

Copy link
Member

left a comment

Thanks! 🎉

@styfle styfle merged commit 2a9f782 into markedjs:master Dec 20, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@mccraveiro mccraveiro deleted the mccraveiro:blockquote branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.