Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print ENOENT errors on cli #1396

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@mccraveiro
Copy link
Contributor

commented Dec 20, 2018

Marked version: master branch

Markdown flavor: n/a

Description

Hide the JS stack trace on CLI errors

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@UziTech

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

I'm not sure if this is the correct solution. It would be easier to debug with the stack trace.

If we want to fix #205 we should catch that error and show a relevant message.

@mccraveiro

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

@UziTech What message would you show on #205 situation?

I'm not sure that debugging is something one would do while using the cli.
Should we use NODE_ENV to show the stack when in development mode?

@UziTech

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

could be something like

marked: output to nonexistent_dir/test.html: No such directory

The way this PR is right now the output would be

Error: ENOENT, open 'nonexistent_dir/test.html'

which is not much more helpful.

@mccraveiro mccraveiro force-pushed the mccraveiro:cli-error branch from 9c7a2dd to 8f532f0 Dec 20, 2018

@mccraveiro mccraveiro force-pushed the mccraveiro:cli-error branch from 8f532f0 to 327c9d8 Dec 20, 2018

@mccraveiro

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

@UziTech done :)

@mccraveiro mccraveiro changed the title Pretty print errors on cli Pretty print ENOENT errors on cli Dec 20, 2018

@styfle

styfle approved these changes Dec 20, 2018

Copy link
Member

left a comment

LGTM 👍

@styfle styfle merged commit 0fd0a97 into markedjs:master Dec 20, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@mccraveiro mccraveiro deleted the mccraveiro:cli-error branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.