Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag escaping #1397

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@mccraveiro
Copy link
Contributor

commented Dec 20, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

\*not emphasized*
\<br/> not a tag
\[not a link](/foo)
\`not code`
1\. not a list
\* not a list
\# not a heading
\[foo]: /url "not a reference"

Expectation

<p>*not emphasized*
&lt;br/&gt; not a tag
[not a link](/foo)
`not code`
1. not a list
* not a list
# not a heading
[foo]: /url &quot;not a reference&quot;</p>

Result

<p>*not emphasized*
<br/&gt; not a tag
[not a link](/foo)
`not code`
1. not a list
* not a list
# not a heading
[foo]: /url &quot;not a reference&quot;</p>

What was attempted

HTML escaping tag start

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Important: I had to change 2 old tests so they match the spec. Please double check it! :)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@mccraveiro mccraveiro changed the title Fix tag escaping WIP Fix tag escaping Dec 20, 2018

@mccraveiro mccraveiro force-pushed the mccraveiro:escape-tag branch from 7cac87c to e51bca6 Dec 20, 2018

@mccraveiro mccraveiro changed the title WIP Fix tag escaping Fix tag escaping Dec 20, 2018

@UziTech
Copy link
Member

left a comment

On a roll 💯

@styfle

styfle approved these changes Dec 20, 2018

Copy link
Member

left a comment

Grand Slam ⚾️

@styfle styfle merged commit 53d7ba0 into markedjs:master Dec 20, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@mccraveiro mccraveiro deleted the mccraveiro:escape-tag branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.