Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strong tag #1400

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@mccraveiro
Copy link
Contributor

commented Dec 20, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

foo _____

Expectation

<p>foo _____</p>

Result

<p>foo <strong>_</strong></p>

What was attempted

Not matching the strong tag when the same character is the content

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@mccraveiro mccraveiro referenced this pull request Dec 20, 2018
1 of 6 tasks complete

@mccraveiro mccraveiro changed the title Strong tag Fix strong tag Dec 20, 2018

.travis.yml Outdated Show resolved Hide resolved

@mccraveiro mccraveiro force-pushed the mccraveiro:strong-tag branch from a88a562 to d010745 Dec 20, 2018

@styfle

styfle approved these changes Dec 20, 2018

@UziTech UziTech merged commit 7e1088f into markedjs:master Dec 20, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details

@mccraveiro mccraveiro deleted the mccraveiro:strong-tag branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.