Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies to last stable #1409

Merged
merged 1 commit into from Jan 14, 2019

Conversation

@Feder1co5oave
Copy link
Contributor

commented Jan 13, 2019

Update devDependencies to versions found at https://david-dm.org/markedjs/marked?type=dev

Had to disable new eslint rule to avoid introducing codebase changes. We have mixed type of literal objects:

{key: "value"}
{ key: "value" }

so we might go for one or the other, or leave them as they are.
If we consider linting more aggressively, also the rule space-before-function-paren can be enforced, and we might take the chance and change indentation warnings into errors so they're caught by the CI robot. Let me know.

update devDependencies to last stable. Disable new `object-curly-spac…
…ing` standard rule (eslint-config-standard#124).
@styfle

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

I personally prefer spaces in object literals such as { key: "value" } and the same for destructuring such as const { key } = obj.

@styfle
styfle approved these changes Jan 13, 2019
Copy link
Member

left a comment

Thanks! These were severely out of date. I seem to recall @UziTech pinning glob-to-regexp for some reason but I'm not sure why.

@Martii

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

@Feder1co5oave

Apologies for the interruption...

... last stable

Do you mean "latest"? Last implies that something is EOL'd from a quick read in my emails/notifications.

@Feder1co5oave

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

@Martii all the versions are described as "stable" at the link above. I think in semver everything is considered "stable" unless a postfix such as "-alpha" or "-rc" is appended.

@Feder1co5oave

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

glob-to-regex@0.3.0 was introduced in #1004 but I can't find the specific reason it was pinned

@styfle styfle requested a review from UziTech Jan 14, 2019

@UziTech

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

I probably just forgot the caret (^) It doesn't look like v0.4.0 should break anything.

@styfle styfle merged commit 5c5de3e into markedjs:master Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (markedjsbot) No known issues
Details
@UziTech UziTech referenced this pull request Feb 18, 2019
11 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.