Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --test man documentation and changes argv parameters test/index.js #1442

Merged
merged 12 commits into from Mar 12, 2019

Conversation

@x13machine
Copy link
Contributor

commented Mar 10, 2019

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Added --test man documentation in response to #1423. I don't know If I'm using the correct groff format. I ran "man -P cat ./marked.1 > marked.1.txt" to write the "marked.1.txt" file. I don't know if that's what I'm suppose to do.
  • Changed the parseArg code in test/index.js because it was using process.argv and not argv.
    var opt = parseArg();

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
lib/marked.js Outdated Show resolved Hide resolved
man/marked.1.txt Outdated Show resolved Hide resolved
@x13machine

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

I meant --minified and not --run. The loose parameter was a mistake.

test/index.js Show resolved Hide resolved
bin/marked Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
man/marked.1.txt Show resolved Hide resolved
@UziTech

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

To make the tests pass you will have to change /test/specs/original/specs-spec.js line 6

-  if (!specTests({stop: true})) {
+  if (!specTests(['', '', '--stop'])) {

x13machine added some commits Mar 11, 2019

test/index.js Outdated Show resolved Hide resolved
test/index.js Show resolved Hide resolved

x13machine added some commits Mar 11, 2019

@x13machine x13machine force-pushed the x13machine:master branch from 698140b to aec8deb Mar 11, 2019

@styfle

styfle approved these changes Mar 12, 2019

@styfle styfle merged commit a685251 into markedjs:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
This was referenced Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.