Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest commit for demo master #1457

Merged
merged 3 commits into from Apr 6, 2019
Merged

use latest commit for demo master #1457

merged 3 commits into from Apr 6, 2019

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Mar 29, 2019

Description

use @master in demo for master version

https://docs-ikjy0vxvf.now.sh/demo/

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@UziTech UziTech mentioned this pull request Mar 29, 2019
@styfle
Copy link
Member

@styfle styfle commented Mar 29, 2019

I think the branch is cached by the CDN for a week or so which is maybe why it wasn’t showing the latest.

styfle
styfle approved these changes Mar 29, 2019
@UziTech
Copy link
Member Author

@UziTech UziTech commented Mar 29, 2019

If that is the case than this won't fix the issue. I wonder If I should grab the latest commit hash and use that.

@styfle
Copy link
Member

@styfle styfle commented Apr 1, 2019

@UziTech That might work. Another alternative is to add a "bust cache" button since there appears to be an API for that (requires an email).

See the full discussion here: jsdelivr/jsdelivr#18101

@UziTech
Copy link
Member Author

@UziTech UziTech commented Apr 1, 2019

Using the latest commit hash seems to be the right way to go.

https://docs-qaob045da.now.sh/demo/

styfle
styfle approved these changes Apr 1, 2019
@UziTech UziTech requested review from davisjam and joshbruce Apr 3, 2019
@UziTech
Copy link
Member Author

@UziTech UziTech commented Apr 3, 2019

I also fixed a bug when using a regular version

https://docs-ikjy0vxvf.now.sh/demo/

@UziTech UziTech changed the title use @master use latest commit for demo master Apr 3, 2019
@joshbruce joshbruce merged commit 69c9e63 into markedjs:master Apr 6, 2019
1 check passed
@UziTech UziTech deleted the demo-master-version branch Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants