Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaks #1507

Merged
merged 2 commits into from Jun 29, 2019
Merged

Fix breaks #1507

merged 2 commits into from Jun 29, 2019

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Jun 28, 2019

Marked version: 0.6.2

Markdown flavor: GitHub Flavored Markdown with breaks

Description

the breaks: true option broke in v0.6.2 because of #1460

This reverts the change only when the breaks option is set to true.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
@UziTech
Copy link
Member Author

@UziTech UziTech commented Jun 28, 2019

This fixes the breaks but it adds back the redos in quadradic_br.js when breaks: true option is used.

@UziTech UziTech requested review from styfle, davisjam and joshbruce Jun 28, 2019
@UziTech
Copy link
Member Author

@UziTech UziTech commented Jun 28, 2019

This should be released soon since this probably affects a lot of marked users

styfle
styfle approved these changes Jun 28, 2019
Copy link
Member

@styfle styfle left a comment

I don't know what is worse, broken breaks or redos 🤷‍♂

@davisjam
Copy link
Contributor

@davisjam davisjam commented Jun 29, 2019

Let's get this merged. I think fixing a behavior regression is more important than a performance regression.

@UziTech UziTech merged commit c95667f into markedjs:master Jun 29, 2019
1 check passed
@UziTech UziTech deleted the fix-breaks branch Jun 29, 2019
@fdietze
Copy link

@fdietze fdietze commented Jun 29, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants