Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link parenthesis #1509

Merged
merged 2 commits into from Jul 2, 2019
Merged

Link parenthesis #1509

merged 2 commits into from Jul 2, 2019

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Jul 1, 2019

Marked version: master

Description

Fix multiple inline links with parenthesis around them

Markdown

([one](http://example.com/1)) ([two](http://example.com/2))

Expected

(one) (two)

Actual

(one (two)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR
styfle
styfle approved these changes Jul 1, 2019
Copy link
Member

@styfle styfle left a comment

Thanks 👍

@UziTech
Copy link
Member Author

@UziTech UziTech commented Jul 1, 2019

I found a few more edge cases that were broken and fixed them

Copy link
Contributor

@davisjam davisjam left a comment

No opinion.

@UziTech UziTech merged commit 6bae3a2 into markedjs:master Jul 2, 2019
1 check was pending
@UziTech UziTech deleted the link-paren branch Jul 2, 2019
@UziTech UziTech mentioned this pull request Jul 5, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants