Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make No Empty Line Required Before GFM Tables #2298

Merged
merged 4 commits into from Nov 25, 2021

Conversation

@EmmetZC
Copy link
Contributor

@EmmetZC EmmetZC commented Nov 22, 2021

Uses table pattern to interrupt paragraph. So an empty line won't be required for GFM tables.
Test cases added for this change.

Marked version: 4.0.4

Markdown flavor: GitHub Flavored Markdown

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

@vercel vercel bot commented Nov 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/3jZ6Pe17jPQAYApsgYCY8szu17ZJ
Preview: https://markedjs-git-fork-emmetzc-fix-gfmtablenewline-markedjs.vercel.app

test/specs/gfm/gfm.0.29.json Outdated Show resolved Hide resolved
Copy link
Member

@UziTech UziTech left a comment

💯

styfle
styfle approved these changes Nov 24, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@UziTech UziTech merged commit 5714212 into markedjs:master Nov 25, 2021
10 checks passed
github-actions bot pushed a commit that referenced this issue Nov 25, 2021
## [4.0.5](v4.0.4...v4.0.5) (2021-11-25)

### Bug Fixes

* table after paragraph without blank line ([#2298](#2298)) ([5714212](5714212))
@github-actions
Copy link

@github-actions github-actions bot commented Nov 25, 2021

🎉 This PR is included in version 4.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@EmmetZC EmmetZC deleted the fix/gfm_table_newline branch Nov 25, 2021
vikunja-bot pushed a commit to go-vikunja/frontend that referenced this issue Nov 25, 2021
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [marked](https://marked.js.org) ([source](https://github.com/markedjs/marked)) | dependencies | patch | [`4.0.4` -> `4.0.5`](https://renovatebot.com/diffs/npm/marked/4.0.4/4.0.5) |

---

### Release Notes

<details>
<summary>markedjs/marked</summary>

### [`v4.0.5`](https://github.com/markedjs/marked/releases/v4.0.5)

[Compare Source](markedjs/marked@v4.0.4...v4.0.5)

##### Bug Fixes

-   table after paragraph without blank line ([#&#8203;2298](markedjs/marked#2298)) ([5714212](markedjs/marked@5714212))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1085
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants