Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multiline setext headings #2655

merged 1 commit into from Nov 20, 2022


Copy link

@UziTech UziTech commented Nov 13, 2022

Marked version: 4.2.2


Allow multiline setext headings. This fixes 3 Setext headings spec tests but breaks one test that was only passing because we didn't allow multiline setext headings.

The last setext heading test will actually have to be fixed in the blockquote tokenizer.

There was also one unit test that was wrong so I just deleted it. There are other tests that prevent the same regression.


  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.


In most cases, this should be a different person than the contributor.

Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website Ready (Inspect) Visit Preview Nov 13, 2022 at 7:03AM (UTC)

Copy link
Member Author

UziTech commented Nov 19, 2022

Any objections to merging this?

@UziTech UziTech merged commit 4aee878 into markedjs:master Nov 20, 2022
10 checks passed
@UziTech UziTech deleted the fix-setext-heddings branch November 20, 2022 16:06
github-actions bot pushed a commit that referenced this pull request Nov 20, 2022
## [4.2.3](v4.2.2...v4.2.3) (2022-11-20)

### Bug Fixes

* fix entity specs ([#2652](#2652)) ([36a2b63](36a2b63))
* fix link reference definitions specs ([#2654](#2654)) ([b7eea95](b7eea95))
* fix marked.use with multiple args ([#2651](#2651)) ([73a7bf5](73a7bf5))
* fix multiline setext headings ([#2655](#2655)) ([4aee878](4aee878))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants