Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove quotes at the end of gfm autolink #2673

Merged
merged 1 commit into from Dec 7, 2022
Merged

fix: remove quotes at the end of gfm autolink #2673

merged 1 commit into from Dec 7, 2022
+9 −3

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 4, 2022

Marked version: 4.2.3

Markdown flavor: GitHub Flavored Markdown

Description

GFM spec states that trailing puncutation (?, !, ., ,, :, *, _, and ~) are removed from the url but in the implementation ' and " are also removed. This technically breaks the GMF spec but follows the implementation closer.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Dec 4, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 4:03AM (UTC)

@UziTech UziTech merged commit 697ac2a into markedjs:master Dec 7, 2022
10 checks passed
@UziTech UziTech deleted the autolink-quotes branch December 7, 2022 07:44
github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
@semantic-release-bot
chore(release): 4.2.4 [skip ci]
f2f9969 
## [4.2.4](v4.2.3...v4.2.4) (2022-12-07)

### Bug Fixes

* loose list items are loose ([#2672](#2672)) ([df4eb0e](df4eb0e))
* remove quotes at the end of gfm autolink ([#2673](#2673)) ([697ac2a](697ac2a))
* use paragraph token in blockquote in list ([#2671](#2671)) ([edc857c](edc857c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild

@davisjam davisjam

@joshbruce joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLs wrapped in quotes include closing quote
2 participants
@UziTech @styfle