Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes add patch #431

Closed

Conversation

@paolocasarini
Copy link

commented Jun 1, 2014

I've added the footnotes management to marked with the syntax in the MultiMarkdown project. I'm the CTO of a leading italian publisher and I think footnotes could be very useful for the gitbook project.

@adam-p adam-p referenced this pull request Jun 14, 2014
@AaronO

This comment has been minimized.

Copy link

commented Aug 11, 2014

@paolocasarini Hey, I'm one of the two authors of gitbook.

We forked marked as kramed (https://github.com/GitbookIO/kramed), the idea being to move towards kramdown support and also be able to move forward without having to wait on @chjj to merge PRs on marked (he's done awesome work up till now with, it just seems like he's busy with other more important things these days).

Do you want to submit your PR to kramed (you'll need to make a few small modifications) and I'll happily merge it.

Thanks !

AaronO added a commit to GitbookIO/kramed that referenced this pull request Aug 11, 2014
Add footnote parsing/rendering support
Fixes GitbookIO/gitbook#395, fixes GitbookIO/gitbook#134, fixes
GitbookIO/gitbook#237

Based off markedjs/marked#431
@13protons

This comment has been minimized.

Copy link

commented Sep 16, 2014

@paolocasarini Footnotes seem to work, but they're rendered inside a paragraph tag despite this code that should render them inside a blockquote:

https://github.com/paolocasarini/marked/blob/d833046f0258710413591ef4bee3181caddbaf21/lib/marked.js#L891-L897

Can you help debug? I'd like to get that <blockquote> tag rather than a <p> from the Renderer.prototype.footnote definition.

@paolocasarini

This comment has been minimized.

Copy link
Author

commented Sep 16, 2014

Yes, I'll check it.

Paolo
Il 16/set/2014 07:50 "Alan Languirand" notifications@github.com ha
scritto:

@paolocasarini https://github.com/paolocasarini Footnotes seems to
work, but they're rendered inside a paragraph tag despite this code that
should render them inside a blockquote:

https://github.com/paolocasarini/marked/blob/d833046f0258710413591ef4bee3181caddbaf21/lib/marked.js#L891-L897

Can you help debug? I'd like to get that

tag rather than a

from the Renderer.prototype.footnote definition.


Reply to this email directly or view it on GitHub
#431 (comment).

@paolocasarini

This comment has been minimized.

Copy link
Author

commented Oct 1, 2014

Yes you could use a simple

instead of a

just replacing it
in the code you highlighted. To me, the important thing is to allow
specific representation for footnotes. For example, instead a blockquote we
can use a specific class:

... or even better

...

I used the blockquote tag because there is no use of class attributes in
the html that is produced, just to empathize the different the different
role between normal text and footnotes.

I also know that on kramed project my pull request has been ported (as is),
but I know hoe it is used:
GitbookIO/kramed@e5604a6
GitbookIO/kramed@e5604a6

Sorry, but I'm sure to have well understood your questione so I ask you if
I have answered to your question...

Best,
Paolo.

2014-09-16 7:50 GMT+02:00 Alan Languirand notifications@github.com:

@paolocasarini https://github.com/paolocasarini Footnotes seems to
work, but they're rendered inside a paragraph tag despite this code that
should render them inside a blockquote:

https://github.com/paolocasarini/marked/blob/d833046f0258710413591ef4bee3181caddbaf21/lib/marked.js#L891-L897

Can you help debug? I'd like to get that

tag rather than a

from the Renderer.prototype.footnote definition.


Reply to this email directly or view it on GitHub
#431 (comment).

Paolo Casarini
Software consultant
P.IVA 02465691208
Direct Tel: +39-339-3463882

@davidmerfield

This comment has been minimized.

Copy link

commented Jul 31, 2015

Hi @paolocasarini thank you for this, it helped immensely. Are you able to modify it to include inline footnotes?

What about inline footnotes.^[Inlines notes are easier to write, since you don't have to pick an identifier.]

@joshbruce joshbruce added this to Queue in PRs Dec 1, 2017

@joshbruce

This comment has been minimized.

Copy link
Member

commented Jan 21, 2018

Closing as stale, no tests, and merge conflicts.

@joshbruce joshbruce closed this Jan 21, 2018

@joshbruce joshbruce moved this from Queue to Close in PRs Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.