New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practical Redux Part 4 - WIP commits #1

Closed
wants to merge 23 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@markerikson
Owner

markerikson commented Nov 22, 2016

The original WIP commits for the progress described in Practical Redux Part 4: UI Layout and Project Structure.

markerikson added some commits Nov 15, 2016

Add ability to show a content component for each tab
Updated App CSS to only center header, instead of everything.  This
keeps the tab contents from centering as well.
Enable absolute import paths (such as "features/a/SomeComponent")
There's been numerous requests for Create-React-App to support having
imports resolved relative to the "src" folder.  The semi-documented
solution is to have a NODE_PATH environment variable, which will be
used in the resolution process.  It's apparently also possible to
specify that variable in a file named ".env".

References:

facebook/create-react-app#476
facebook/create-react-app#693
facebook/create-react-app#741
Rewrite tabs handling to be driven by Redux
Moved TabBar to common/components
Added reducer utility functions
Added tab handling logic
Added TabContainer
Added tabs reducer to root reducer
Removed dead test reducer
Changed TabBar to be a functional component, since it's now stateless
Upgrade Semantic-UI-React to 0.61.0
I was previously on 0.60.9.  Unfortunately, that apparently had a huge
performance issue, due to the way Lodash was being used to omit props
that components didn't handle themselves.  That resulted in increasingly
slow performance to switch tabs as I added more components per tab
panel (and not that many components, either!).  The perf issue was
fixed in 0.60.10, naturally.

References:

Semantic-Org/Semantic-UI-React#860
Semantic-Org/Semantic-UI-React#864
Fix linting complaints
Removed unused component imports
Added keys to tabs and tab panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment