New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practical Redux Part 4 - Final #2

Merged
merged 14 commits into from Nov 22, 2016

Conversation

Projects
None yet
1 participant
@markerikson
Owner

markerikson commented Nov 22, 2016

The cleaned-up final commits for the progress described in Practical Redux Part 4: UI Layout and Project Structure.

markerikson added some commits Nov 20, 2016

Add Semantic-UI-React and Semantic-UI-CSS
Important note: Semantic-UI-React 0.60.9 had a major perf issue with
how Lodash was being used to omit props. This was resolved in 0.60.10,
so future installs should be okay.

References:
Semantic-Org/Semantic-UI-React#860
Semantic-Org/Semantic-UI-React#864
Use Semantic-UI and clean up unused code
Set page title in HTML template
Removed unused index.css
Removed logo from header and removed unused logo file
Shrank header and removed unused CSS
Imported Semantic-UI CSS into index
Added a Semantic-UI Header into the page header
Removed SampleComponent from App and removed the file
Add ability to swap visible tab component based on active tab
Added rendering of a panel component for each tab definition, with
toggling of visibility based on the active tab

Added initial dummy components for existing tab definitions
Enable absolute import paths (such as "features/a/SomeComponent")
There's been numerous requests for Create-React-App to support having
imports resolved relative to the "src" folder.  The semi-documented
solution is to have a NODE_PATH environment variable, which will be
used in the resolution process.  It's apparently also possible to
specify that variable in a file named ".env".

References:

facebook/create-react-app#476
facebook/create-react-app#693
facebook/create-react-app#741
Rewrite tabs handling to be driven by Redux
Added reducer utility functions
Added tab handling logic
Added tabs reducer to root reducer
Removed dead test reducer

Rewrote TabBarContainer to be a connected version of TabBar

@markerikson markerikson merged commit b208faf into master Nov 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment