Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian Localization #6

Merged
merged 2 commits into from Aug 2, 2020

Conversation

dpolyakov
Copy link
Contributor

@dpolyakov dpolyakov commented Jun 25, 2020

Hello.

I think it can be usefull

@jhauraw jhauraw changed the title add localization to russian Add Russian Localization Jul 1, 2020
@jhauraw
Copy link
Member

jhauraw commented Jul 1, 2020

@dpolyakov thank you for your contribution. This is a good idea.

I feel though it needs more of the words translated to Russian. For example the English word "Warning" surely has an equivalent Russian word? And social media names? So if you can translate all the words then I can merge it.

I just noticed my English translation for the word "Infromation" is spelled wrong. I just pushed a commit to fix that.

@dpolyakov dpolyakov force-pushed the feature/ru-localization branch 2 times, most recently from 9336dbc to 4dc6f30 Compare Jul 17, 2020
@dpolyakov dpolyakov force-pushed the feature/ru-localization branch from 4dc6f30 to a14b5b0 Compare Jul 17, 2020
@dpolyakov
Copy link
Contributor Author

dpolyakov commented Jul 17, 2020

@jhauraw fixed.

Social networks names doesn`t need translation

@jhauraw
Copy link
Member

jhauraw commented Jul 23, 2020

@dpolyakov can you please edit the Pull Request and select the "Allow edits from Maintainers box"? Thanks

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@dpolyakov
Copy link
Contributor Author

dpolyakov commented Aug 1, 2020

image

@jhauraw jhauraw merged commit 76bd51b into marketempower:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants