Permalink
Browse files

Revert "ssc: saved mode pages are not implemented"

Incorrect commit.
This patch breaks assumption that MODE DESCRIPTOR block data
can still be set even though the 'save data' is not set.

'save data' bit should be honored for certain MODE pages.

This reverts commit 2d13419e604ed0c0cb8502896b503b6c989dcf76.
  • Loading branch information...
1 parent b3e786f commit aa92930c5bad5c0937ca375e1f2a9d07d7883d9a @markh794 committed Apr 4, 2013
Showing with 4 additions and 5 deletions.
  1. +4 −5 usr/ssc.c
View
@@ -836,11 +836,10 @@ uint8_t ssc_mode_select(struct scsi_cmd *cmd)
memcpy(modeBlockDescriptor, bdb, block_descriptor_sz);
}
- /* Saved mode pages are not implemented */
- if (save_pages) {
- mkSenseBuf(ILLEGAL_REQUEST, E_INVALID_FIELD_IN_CDB, sam_stat);
- MHVTL_DBG(1, " Saved mode pages are not implemented.");
- return SAM_STAT_CHECK_CONDITION;
+ /* Ignore mode pages if 'save pages' bit not set */
+ if (!save_pages) {
+ MHVTL_DBG(1, " Save pages bit not set. Ignoring page data");
+ return SAM_STAT_GOOD;
}
/* Page Format: Reference HP LTO 5 Vol 3_E2

0 comments on commit aa92930

Please sign in to comment.