Never use empty href in links #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith window.location. Use "#"
jaysalvat
added a commit
that referenced
this pull request
Jun 2, 2014
|
Thanks for your contribution. I will release a version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Markitup in an Ajax environment, I have to exclude Markitup buttons from Ajax navigation using their
hrefvalue. But…Doing a
console.log(event.currentTarget.href);would outputwindow.location.hrefvalue instead of nothing. So I had to set every buttonhrefto "#" preventing this weird behaviour.(My grunt setup created a minified version, you can get rid of it)