Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Feb 6, 2012
Commits on Jan 18, 2012
  1. @brianmario

    Merge pull request #239 from GarthSnyder/969a3a6dfac49deb44ae6ff7db71…

    brianmario authored
    …ad53c7da195f
    
    Fix for issue #238
Commits on Jan 16, 2012
  1. @GarthSnyder
Commits on Dec 21, 2011
  1. @brianmario

    Merge pull request #232 from tmtm/utf8mb4

    brianmario authored
    utf8mb4 charset supoprt
  2. @tmtm

    add utf8mb4 charset

    tmtm authored
Commits on Dec 10, 2011
  1. @benmcredmond

    Moved/tidied tests. Bug fix in client.c

    benmcredmond authored
    The bug fix in client.c is less than ideal but there isn't really
    another option without some rearchitecting. Basically, wrapper->active
    should not be set to 0 when mysql_use_result is being used until we
    have iterated through the full result set (as the wrpaper is infact
    still active). Unfortunately, we would need to change this within
    Mysql2::Result, which isn't possible at the moment unless we pass the
    client to the result object (which seems overkill). So, for now, the
    query will fail with a "commands out of sync" error.
    
    # Please enter the commit message for your changes. Lines starting
    # with '#' will be ignored, and an empty message aborts the commit.
    # On branch master
    # Your branch is ahead of 'origin/master' by 1 commit.
    #
    # Changes to be committed:
    #   (use "git reset HEAD <file>..." to unstage)
    #
    #	modified:   ext/mysql2/client.c
    #	modified:   spec/mysql2/client_spec.rb
    #	modified:   spec/mysql2/result_spec.rb
    #
    # Untracked files:
    #   (use "git add <file>..." to include in what will be committed)
    #
    #	Gemfile.lock
  2. @benmcredmond

    Added some tests

    benmcredmond authored
Commits on Dec 6, 2011
  1. @brianmario
  2. @brianmario
Commits on Dec 3, 2011
  1. @benmcredmond

    Consistency++

    benmcredmond authored
  2. @benmcredmond

    Fixed some icky ifs

    benmcredmond authored
  3. @benmcredmond

    Fix issue with "should cache previously yielded results by default"

    benmcredmond authored
    Was accidentally overwriting wrapper->numberOfRows on iterations after
    first.
Commits on Dec 1, 2011
  1. @brianmario

    reacquire GVL before retrying on EINTR on connect

    Eric Wong authored brianmario committed
    If signals are received, we must reacquire the GVL to let
    (Ruby-level) signal handlers run.  Otherwise, it may be
    impossible to effectively cancel/interrupt a slow connection
    negotiation.
    
    Fortunately, connecting to MySQL servers is rare and rarely
    interrupted (or even interruptible) by signal handlers, so
    maybe nobody noticed this bug.
  2. @brianmario

    avoid potentially unsafe Ruby C API usage w/o GVL

    Eric Wong authored brianmario committed
    Using StringValuePtr() /can/ potentially allocate a new String
    object.  This allocation _currently_ impossible in our codebase,
    but to prevent future/potential bugs from appearing, we'll
    avoid StringValuePtr() (and any functions not explicitly
    supported w/o GVL) in nogvl_* regions.
  3. @brianmario

    revert to using xmalloc/xfree for allocations

    Eric Wong authored brianmario committed
    I've (re)read our usage of them and observed no bad interactions
    with the Ruby GC and no need to use RB_GC_GUARD anywhere.
    
    xmalloc() does error-checking for us, so we'll raise
    NoMemoryError instead of a segfaulting when/if malloc() fails to
    release memory.
    
    xmalloc() may increase the frequency of GC invocation in MRI
    because it bumps the malloc counter (and xfree() cannot
    decrement it), but MRI 1.9.3+ users can set a higher
    RUBY_GC_MALLOC_LIMIT to reduce GC frequency (or improve GC :P).
  4. reacquire GVL before retrying on EINTR on connect

    Eric Wong authored
    If signals are received, we must reacquire the GVL to let
    (Ruby-level) signal handlers run.  Otherwise, it may be
    impossible to effectively cancel/interrupt a slow connection
    negotiation.
    
    Fortunately, connecting to MySQL servers is rare and rarely
    interrupted (or even interruptible) by signal handlers, so
    maybe nobody noticed this bug.
  5. avoid potentially unsafe Ruby C API usage w/o GVL

    Eric Wong authored
    Using StringValuePtr() /can/ potentially allocate a new String
    object.  This allocation _currently_ impossible in our codebase,
    but to prevent future/potential bugs from appearing, we'll
    avoid StringValuePtr() (and any functions not explicitly
    supported w/o GVL) in nogvl_* regions.
  6. revert to using xmalloc/xfree for allocations

    Eric Wong authored
    I've (re)read our usage of them and observed no bad interactions
    with the Ruby GC and no need to use RB_GC_GUARD anywhere.
    
    xmalloc() does error-checking for us, so we'll raise
    NoMemoryError instead of a segfaulting when/if malloc() fails to
    release memory.
    
    xmalloc() may increase the frequency of GC invocation in MRI
    because it bumps the malloc counter (and xfree() cannot
    decrement it), but MRI 1.9.3+ users can set a higher
    RUBY_GC_MALLOC_LIMIT to reduce GC frequency (or improve GC :P).
Commits on Nov 16, 2011
  1. @brianmario
  2. @brianmario
  3. @brianmario
Commits on Nov 10, 2011
  1. @brianmario

    Merge pull request #198 from JonathonMA/doc-test-requirements

    brianmario authored
    Document user and database requirements for tests
  2. grrrrrrrr

    Ben McRedmond authored
  3. More stupid vim indentation

    Ben McRedmond authored
  4. Change :streaming to :stream

    Ben McRedmond authored
  5. @woahdae @brianmario

    Change mysql error detection strategy

    woahdae authored brianmario committed
    Previous to this commit, some mysql connection errors were not detected
    by the client.
    
    This commit changes from implicit error detection via checking
    mysql_field_count() to explicit detection via mysql_errno().
    
    http://dev.mysql.com/doc/refman/5.0/en/null-mysql-store-result.html
  6. @brianmario
  7. @brianmario

    Merge pull request #224 from woahdae/mysql_err_check

    brianmario authored
    Change mysql error detection strategy
  8. @woahdae

    Change mysql error detection strategy

    woahdae authored
    Previous to this commit, some mysql connection errors were not detected
    by the client.
    
    This commit changes from implicit error detection via checking
    mysql_field_count() to explicit detection via mysql_errno().
    
    http://dev.mysql.com/doc/refman/5.0/en/null-mysql-store-result.html
  9. Think I actually fixed indentation this time

    Ben McRedmond authored
  10. Accidentally committed Gemfile.lock

    Ben McRedmond authored
  11. fixing vim's messed up indentation

    Ben McRedmond authored
  12. Updated README to describe streaming

    Ben McRedmond authored
  13. Initial implementation of mysql_use_result, accessible by setting :st…

    Ben McRedmond authored
    …reaming => true when querying
Commits on Nov 9, 2011
  1. @brianmario
Something went wrong with that request. Please try again.