Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Key length issues #2

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

aaroncampbell commented Sep 5, 2011

The option_name field in the options table is varchar(64). Currently 'transient_timeout' + 'tlc_update__' comes out to 31 characters, which means you only have 33 characters for $key. A common practice is to make $key an md5 prepended with something to make it obvious what it's for (twp_{md5}). By shortening tlc_update__ to allow longer keys you can allow a 37 character key. Then we limit the key length to 37 to prevent transient timeout key names from being too long.

Contributor

aaroncampbell commented Sep 6, 2011

After this pull request I started working on another project, which was retry_in. For some reason when I pushed that to my fork it added it here. I guess I need to learn more about branches in git, but I can't figure out how to remove it from this request.

@markjaquith markjaquith closed this Sep 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment