Added test for two-way SSL. #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
force-pushed
the
feature/2way-ssl-test
branch
2 times, most recently
from
0f4032b to
d2ec51e
Compare
Made a couple of small improvements to how errors are reported for a couple of the scenarios in this test too. Removed ignored/obsolete test for certificate auth that I could never get to work.
rjrudin
force-pushed
the
feature/2way-ssl-test
branch
from
d2ec51e to
287387d
Compare
BillFarber
approved these changes
Aug 18, 2023
| throw new MarkLogicIOException(String.format("SSL error occurred: %s; ensure you are using a valid certificate " + | ||
| "if the MarkLogic app server requires a client certificate for SSL.", message)); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
So, if e is an SSL Exception but doesn't contain readHandshakeRecord, then we're good with the normal MarkLogicIOException?
Contributor
Author
There was a problem hiding this comment.
Right - I was getting the normal MarkLogicIOException originally, and felt like this was a special case where it'd be helpful to mention checking the use of certificates when "readHandshakeRecord" is in the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a couple of small improvements to how errors are reported for a couple of the scenarios in this test too.
Removed ignored/obsolete test for certificate auth that I could never get to work.