From 2377dcaf7fcf19b96091b3a4620305ba72e71905 Mon Sep 17 00:00:00 2001 From: Rob Rudin Date: Mon, 27 Oct 2025 10:57:16 -0400 Subject: [PATCH] MLE-24892 Cleaning up test dependencies Unfortunately can't upgrade to JUnit5 in ml-development-tools, far too many breaking changes to fix for now. --- marklogic-client-api/build.gradle | 2 -- .../com/marklogic/client/test/rows/TransformDocTest.java | 2 -- ml-development-tools/build.gradle | 8 ++------ 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/marklogic-client-api/build.gradle b/marklogic-client-api/build.gradle index 8d0aca524..11855b87b 100644 --- a/marklogic-client-api/build.gradle +++ b/marklogic-client-api/build.gradle @@ -38,8 +38,6 @@ dependencies { testImplementation 'org.junit.jupiter:junit-jupiter:5.14.0' - // Forcing junit version to avoid vulnerability with older version in xmlunit - testImplementation 'junit:junit:4.13.2' testImplementation 'org.xmlunit:xmlunit-legacy:2.10.4' testImplementation project(':examples') diff --git a/marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java b/marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java index f7ed8233b..9e18896f5 100644 --- a/marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java +++ b/marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java @@ -13,9 +13,7 @@ import com.marklogic.client.io.marker.AbstractWriteHandle; import com.marklogic.client.row.RowRecord; import com.marklogic.client.test.Common; -import com.marklogic.client.test.MarkLogicVersion; import com.marklogic.client.test.junit5.RequiresML11; -import org.junit.Before; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; diff --git a/ml-development-tools/build.gradle b/ml-development-tools/build.gradle index 9b0f67f85..37836848e 100644 --- a/ml-development-tools/build.gradle +++ b/ml-development-tools/build.gradle @@ -29,13 +29,9 @@ dependencies { // Sticking with this older version for now as the latest 1.x version introduces breaking changes. implementation 'com.networknt:json-schema-validator:1.0.88' - // Not yet migrating this project to JUnit 5. Will reconsider it once we have a reason to enhance - // this project. + // Sticking with JUnit 4 as there are no vulnerabilities with it, and shifting to JUnit 5 in this module will be + // a significant and tedious effort. testImplementation 'junit:junit:4.13.2' - testImplementation 'org.xmlunit:xmlunit-legacy:2.10.4' - testCompileOnly gradleTestKit() - - testImplementation "com.squareup.okhttp3:okhttp:${okhttpVersion}" } // Added to avoid problem where processResources fails because - somehow - the plugin properties file is getting