Skip to content

Caching XMLOutputFactory to improve performance (fixes #474) #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sammefford merged 2 commits into from
Nov 8, 2017
Merged

Caching XMLOutputFactory to improve performance (fixes #474) #477

sammefford merged 2 commits into from
Nov 8, 2017

Conversation

@robsman
Copy link
Contributor

@robsman robsman commented Sep 12, 2016 •
edited
Loading

Introducing XmlFactories as a means to retrieve a shared XMLOutoutFactory. Also consolidating factory initialization into a common makeNewOutputFactory method.

This change is intended to address the main concerns of #474.

Robert Sauer added 2 commits October 24, 2016 18:07
Caching Utilities' XMLOutputFactory to improve performance
0acfebe 
Intruducing a new XmlFactories class as a suggested place to conveniently retrieve properly configured
XMLFactories. Provides methods to access shared instances or to retrieve a freshly created instance
(if really needed).
Replace remaining invocations of XMLOutputFactory::newInsatnce with X…
7b3b1b2 
…mlFactories::getOutputFactory
@robsman robsman force-pushed the feature/xml-factories-caching branch from 358e53b to 7b3b1b2 Compare October 24, 2016 16:59
@robsman robsman mentioned this pull request Oct 24, 2016
Closed
@joecrean
Copy link

joecrean commented Nov 5, 2017 •
edited
Loading

hey guys @sammefford
I have checking out the 3.0.8 version and saw that this PR is not fully integrated in there : the new CachedInstancePerThreadSupplier is there but no-one is using it i.e. all the other changes apart from the one in Utilities.java have not been merged in.. am i reading that right?

@sammefford
Copy link
Contributor

sammefford commented Nov 7, 2017

@joecrean this pull request isn't integrated. I'm curious where you're seeing CachedInstancePerThreadSupplier in the code as I don't see it. I'll get this integrated.

@joecrean
Copy link

joecrean commented Nov 7, 2017 via email •
edited by jmakeig
Loading

@sammefford sammefford merged commit 7b3b1b2 into marklogic:3.0-develop Nov 8, 2017
sammefford added a commit that referenced this pull request Nov 8, 2017
@sammefford
fix #474 - integrate PR #477, caching XMLOutputFactory to improve per…
7a704e6 
…formance
@sammefford sammefford added test and removed new labels Nov 8, 2017
@sammefford sammefford assigned georgeajit and unassigned sammefford Nov 8, 2017
sammefford added a commit that referenced this pull request Nov 8, 2017
@sammefford
fix #474 - integrate PR #477, caching XMLOutputFactory to improve per…
b7ec224 
…formance, from commit 7a704e6
@sammefford
Copy link
Contributor

sammefford commented Nov 8, 2017

@joecrean the change is now on the 3.0-develop and develop branches. If you want, you can pull and build a copy that includes the changes.

@joecrean
Copy link

joecrean commented Nov 9, 2017

@sammefford thanks Sam!! hey just pondering my next steps here.. any idea of the timelines for a release on 3.0.x?

@sammefford
Copy link
Contributor

sammefford commented Nov 9, 2017

Nothing is scheduled right now. But I wouldn't be surprised to see it come early next year.

@robsman robsman mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@georgeajit georgeajit

Labels

Bug minor test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robsman @joecrean @sammefford @jmakeig @georgeajit