New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround CMA payload issues #1334

Merged
merged 1 commit into from Sep 8, 2018

Conversation

Projects
None yet
2 participants
@ndw
Member

ndw commented Sep 8, 2018

This cleans up the payloads so that they're idempotent.

@ndw ndw requested review from grechaw and ehennum Sep 8, 2018

@grechaw

grechaw approved these changes Sep 8, 2018

Ill merge this PR then take another look at this plural thing. It's not the first time something has been up with plurals and Jim had to tweak some static array of same

@@ -1,6 +1,6 @@
{
"config": {
"amps": [
"amp": [

This comment has been minimized.

@grechaw

grechaw Sep 8, 2018

Member

did you try this? As I recall I the schema validation prevented me from submitting this with 'amp', one of those plural issues

@grechaw

grechaw Sep 8, 2018

Member

did you try this? As I recall I the schema validation prevented me from submitting this with 'amp', one of those plural issues

This comment has been minimized.

@grechaw

grechaw Sep 8, 2018

Member

works -- i think when i first added the plural, it was because i had not installed the modules db yet. with sec* builtins that's an error, with CMA it's silent fail. So thanks for this pR, it's all good.

@grechaw

grechaw Sep 8, 2018

Member

works -- i think when i first added the plural, it was because i had not installed the modules db yet. with sec* builtins that's an error, with CMA it's silent fail. So thanks for this pR, it's all good.

@grechaw grechaw merged commit 5141c53 into marklogic:DHaaS-develop Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment