DEVEXP-561 Now supporting REST API transactions #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
force-pushed
the
feature/with-transaction
branch
from
57c4155 to
27e0bde
Compare
BillFarber
reviewed
Oct 4, 2023
| "/v1/transactions", | ||
| params=params, | ||
| headers={"Accept": "application/json"}, | ||
| ) |
Contributor
There was a problem hiding this comment.
Strangely, this doesn't match the documentation at https://docs.marklogic.com/REST/POST/v1/transactions
Contributor
Author
There was a problem hiding this comment.
Do you mean the use of the "Accept" header? I may have eagerly added that, I'll try removing it.
I'm also going to change the code for when a transaction can't be committed / rolled back, seems like raise_for_status() should be used there.
Contributor
There was a problem hiding this comment.
Also that the documentation says to use the "Location" header in the response (which I find strange).
Contributor
Author
There was a problem hiding this comment.
Added comments, the docs are incorrect.
rjrudin
force-pushed
the
feature/with-transaction
branch
from
27e0bde to
e4df27d
Compare
BillFarber
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.