Releasing 1.0.0 #89
Releasing 1.0.0 #89
Conversation
I am running "gradle -i bintrayUpload" from the root project directory, and all 8 artifacts are published seemingly successfully, but the bintray plugin still throws an error. The notes on the 1.8.4 release imply that 1.8.4 fixes a bug regarding publishing something multiple times, but that appears to be the error. But, the packages still seem to be uploaded successfully.
- Description of marklogic-unit-test and marklogic-junit - Links to sample projects - Moving contributing data to wiki
This allows for marklogic-junit5 to be published under marklogic-community
Adding instructions for getting started using marklogic-unit-test.
- Test names that started with the suite name no longer throw a module not found error.
- Adding a better failure message
Changing Travis CI distribution to Trusty which still supports Oracle JDK 8
|
I think the above failure is pointing out that the master branch still has the old Travis CI distribution, which is no longer working with Oracle JDK 8. I believe the commit to use the trusty distribution fixes the issue ( So I think we're OK to continue with the merge to master assuming the code review passes. I'm hoping to finish this PR on Monday and release 1.0.0 at that time. |
hansenmc
left a comment
hansenmc
left a comment
There was a problem hiding this comment.
I found a handful of other things that should probably be adjusted.
I submitted them as separate PRs, so you can decide whether to pull in now or if you want to defer and pull them in post 1.0 release.
Correcting the JavaDocs. Several methods had @param that did not exist
Questions or Problem linking to non-existent anchor. Removing it.
…orms (#95) Can now take advantage of the test-dir parameter in an XSLT transform.
name() will return the namespace-prefix of the instance XML document, which may not use "error". Changing to use the self:: axis and use XPath to test if it is an error:error element.
No need to repeat the type on the right hand side
|
I noticed that the marklogic-unit-test-modules test-helper.xqy references " Not sure if we want to leave that in there as an ode to it's origins, or if we wanted to remove all references to Roxy. |
|
Also, before publishing the copyright year should be updated to the current year. There are several files that have |
…acter encoding of the system to convert the string to a byte array. (#98) Instead, use new InputSource(new StringReader(xml)) The StringReader avoids having to convert to a byte array and will send the character stream to the InputSource, which will determine the encoding through standard XML API parse rules.
* Remove unnecessary declaration of logger that is shadowing the logger from LoggingObject that it extends. * Remove unused imports (now that logger is not explicitly initialized here)
No description provided.