Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onBeforeUpdate call timing for legacy components. #1027

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@DylanPiercey
Copy link
Contributor

commented Apr 3, 2018

Description

Currently onBeforeUpdate is called after updating on legacy components in the compatibility layer.
This changes it to be emitted after rendering but before updating the dom.

Motivation and Context

Improves legacy compatibility.

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DylanPiercey DylanPiercey force-pushed the legacy-on-before-update branch from 628c6a4 to aa9b0a5 Apr 3, 2018

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2018

Codecov Report

Merging #1027 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   90.33%   90.34%   +<.01%     
==========================================
  Files         304      304              
  Lines       11519    11525       +6     
==========================================
+ Hits        10406    10412       +6     
  Misses       1113     1113
Impacted Files Coverage Δ
...c/components/legacy/defineWidget-legacy-browser.js 95.4% <100%> (+0.34%) ⬆️
src/components/legacy/renderer-legacy.js 97.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82db00e...e1c6239. Read the comment docs.

@DylanPiercey DylanPiercey force-pushed the legacy-on-before-update branch from aa9b0a5 to e1c6239 Apr 3, 2018

@coveralls

This comment has been minimized.

Copy link

commented Apr 3, 2018

Coverage Status

Coverage increased (+0.004%) to 90.342% when pulling e1c6239 on legacy-on-before-update into 82db00e on master.

@coveralls

This comment has been minimized.

Copy link

commented Apr 3, 2018

Coverage Status

Coverage increased (+0.005%) to 90.343% when pulling e1c6239 on legacy-on-before-update into 82db00e on master.

@mlrawlings mlrawlings merged commit 0d9ef11 into master Apr 3, 2018

6 checks passed

codecov/patch 100% of diff hit (target 90.33%)
Details
codecov/project 90.34% (+<.01%) compared to 82db00e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 90.343%
Details
licence/cla Contributor License Agreement is signed.
Details

@DylanPiercey DylanPiercey deleted the legacy-on-before-update branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.