New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with CI failing due to check-fomat by running prettier. #1062

Merged
merged 2 commits into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@austinkelleher
Member

austinkelleher commented Jun 21, 2018

It seems that the build keeps failing due to the npm check-format script. Running prettier on all of the files seems to fix the issue. We should consider adding check-format to the normal test script because it is not very clear why the tests fail in the CI otherwise.

@@ -3,20 +3,20 @@
This project adheres to the [eBay Code of Conduct](http://ebay.github.io/codeofconduct).
By participating in this project you agree to abide by its terms.
* Be friendly and patient.

This comment has been minimized.

@austinkelleher

austinkelleher Jun 21, 2018

Member

@mlrawlings I'm not sure if this was formatted this way for any reason, but prettier formatted it.

@austinkelleher

austinkelleher Jun 21, 2018

Member

@mlrawlings I'm not sure if this was formatted this way for any reason, but prettier formatted it.

This comment has been minimized.

@mlrawlings

mlrawlings Jun 21, 2018

Member

Maybe I'm just seeing this is multiple projects, but it seems like prettier keeps switching between - and * for lists. And it's driving me crazy.

@mlrawlings

mlrawlings Jun 21, 2018

Member

Maybe I'm just seeing this is multiple projects, but it seems like prettier keeps switching between - and * for lists. And it's driving me crazy.

@mlrawlings

You'll need to update the prettier version in the package lock as well. I think manually changing the package.json to point to the latest version and running npm i should do the trick without blowing away the whole lock file.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 21, 2018

Codecov Report

Merging #1062 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         305      305           
  Lines       11602    11602           
=======================================
  Hits        10498    10498           
  Misses       1104     1104
Impacted Files Coverage Δ
src/runtime/renderable.js 98.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7613756...9bf33e0. Read the comment docs.

codecov bot commented Jun 21, 2018

Codecov Report

Merging #1062 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         305      305           
  Lines       11602    11602           
=======================================
  Hits        10498    10498           
  Misses       1104     1104
Impacted Files Coverage Δ
src/runtime/renderable.js 98.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7613756...9bf33e0. Read the comment docs.

@mlrawlings mlrawlings merged commit d9805d0 into master Jun 21, 2018

5 checks passed

codecov/patch 100% of diff hit (target 90.48%)
Details
codecov/project 90.48% (+0%) compared to 7613756
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 21, 2018

Coverage Status

Coverage increased (+90.5%) to 90.512% when pulling 9bf33e0 on prettier-files-ci into 7613756 on master.

coveralls commented Jun 21, 2018

Coverage Status

Coverage increased (+90.5%) to 90.512% when pulling 9bf33e0 on prettier-files-ci into 7613756 on master.

@mlrawlings mlrawlings deleted the prettier-files-ci branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment