Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional reference to fragment #1130

Merged
merged 2 commits into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@mlrawlings
Copy link
Member

mlrawlings commented Sep 14, 2018

Description

Fixes #1122

This issue is caused by a fragment's startNode (an empty Text node) missing a property that refers to the fragment itself. It turns out that this property from the DOM Text node is the only reference to the fragment. That should be fine, but apparently IE11 is treating this as a weak reference and garbage collection the fragment anyways.

The fix is to provide an additional reference to the fragment so it doesn't get garbage collected. Fortunately, we have a good place to put this: the keyedElements lookup on the component. In fact, for non-hydrated (client-rendered) fragments, they already are put there.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

mlrawlings added some commits Sep 14, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 14, 2018

Coverage Status

Coverage increased (+0.0008%) to 90.319% when pulling 128926b on ie11-fix into d1d3aa0 on master.

@mlrawlings mlrawlings merged commit ecef7f3 into master Sep 14, 2018

5 checks passed

codecov/patch 100% of diff hit (target 90.31%)
Details
codecov/project 90.31% (+<.01%) compared to d1d3aa0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@DylanPiercey DylanPiercey deleted the ie11-fix branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.