Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with include tag hydration. #1143

merged 3 commits into from Oct 2, 2018


None yet
3 participants
Copy link

DylanPiercey commented Oct 2, 2018


In this PR the include tag is updated to get the proper owner component.
Fragments being matched also use an unmodified key.

Partially fixes #1134.


  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

DylanPiercey added some commits Sep 27, 2018

@DylanPiercey DylanPiercey force-pushed the 1134-repeated-at-tag-keys branch from 20a7a44 to 3b5c231 Oct 2, 2018


This comment has been minimized.

Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #1143 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
+ Coverage   90.51%   90.51%   +<.01%     
  Files         311      311              
  Lines       11787    11788       +1     
+ Hits        10669    10670       +1     
  Misses       1118     1118
Impacted Files Coverage Δ
src/taglibs/core/include-tag.js 94.11% <100%> (ø) ⬆️
src/morphdom/index.js 97.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49055b...661041e. Read the comment docs.

@mlrawlings mlrawlings merged commit fa779a7 into master Oct 2, 2018

5 checks passed

codecov/patch 100% of diff hit (target 90.51%)
codecov/project 90.51% (+<.01%) compared to d49055b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
licence/cla Contributor License Agreement is signed.

This comment has been minimized.

Copy link

coveralls commented Oct 2, 2018

Coverage Status

Coverage decreased (-0.01%) to 90.505% when pulling 661041e on 1134-repeated-at-tag-keys into d49055b on master.

@DylanPiercey DylanPiercey deleted the 1134-repeated-at-tag-keys branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.