Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrator regressions and misc refactoring #1212

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@DylanPiercey
Copy link
Contributor

DylanPiercey commented Dec 28, 2018

Description

  • Fixes control flow attributes on var tag.
  • Fixes w-body to ensure that value exists.
  • Ensures w-body and include properly enclose typeof expressions.
  • Improves printing of unary expressions.
  • Refactor builder.htmlElement calls to omit optional arguments.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.
Fix migrator regressions and misc refactoring
* Fixes control flow attributes on var tag.
* Fixes w-body to ensure that value exists.
* Ensures w-body and include properly enclose typeof expressions.

@DylanPiercey DylanPiercey merged commit ff31597 into master Dec 28, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #1212 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   90.49%   90.51%   +0.01%     
==========================================
  Files         332      332              
  Lines       12213    12213              
==========================================
+ Hits        11052    11054       +2     
+ Misses       1161     1159       -2
Impacted Files Coverage Δ
src/taglibs/migrate/all-tags/include-directive.js 100% <ø> (ø) ⬆️
src/taglibs/migrate/all-templates/render-calls.js 98.03% <ø> (ø) ⬆️
...aglibs/migrate/all-tags/control-flow-directives.js 100% <ø> (ø) ⬆️
src/taglibs/migrate/include-tag.js 100% <100%> (ø) ⬆️
src/taglibs/migrate/layout-put-tag.js 89.47% <100%> (ø) ⬆️
src/taglibs/migrate/layout-placeholder-tag.js 100% <100%> (ø) ⬆️
src/taglibs/migrate/util/import-tag.js 95.23% <100%> (ø) ⬆️
src/taglibs/migrate/all-tags/marko-init.js 91.3% <100%> (ø) ⬆️
src/compiler/ast/UnaryExpression.js 97.72% <100%> (+4.54%) ⬆️
src/taglibs/migrate/util/renderCallToDynamicTag.js 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46ccb5...956a928. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 28, 2018

Coverage Status

Coverage increased (+0.02%) to 90.51% when pulling 956a928 on migrate-regressions into d46ccb5 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 28, 2018

Coverage Status

Coverage increased (+0.02%) to 90.51% when pulling 956a928 on migrate-regressions into d46ccb5 on master.

@DylanPiercey DylanPiercey deleted the migrate-regressions branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.