Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with <title> namespace inside an svg #1284

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@DylanPiercey
Copy link
Contributor

commented Mar 13, 2019

Description

There is currently a whitelist of tags which can be rendered in the SVG namespace if they are within an SVG. This list was missing <title>.

Fixes #1272

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.
@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage remained the same at 90.513% when pulling b3d68d8 on svg-title-namespace into f46c8d5 on master.

@codecov

This comment has been minimized.

Copy link

commented Mar 13, 2019

Codecov Report

Merging #1284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1284   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files         337      337           
  Lines       12375    12375           
=======================================
  Hits        11201    11201           
  Misses       1174     1174
Impacted Files Coverage Δ
...c/compiler/ast/HtmlElement/vdom/HtmlElementVDOM.js 97.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46c8d5...b3d68d8. Read the comment docs.

@DylanPiercey DylanPiercey merged commit c96d181 into master Mar 13, 2019

5 checks passed

codecov/patch Coverage not affected when comparing f46c8d5...b3d68d8
Details
codecov/project 90.51% remains the same compared to f46c8d5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.