New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #651 - Serialize only input and state on top-level server-rendered UI components #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-level UI components in the browser
…globals on re-render
… early mount of UI components in async fragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For context, please see Issue #651 - Proposal: serialize only input and state on top-level server-rendered UI components #651
This Pull Request introduces some important changes to Marko:
state
,input
and properties added to the UI component instance) for top-level UI components is serialized down to the browser (previously, this data was serialized for every UI component rendered on the server)out.global
object is not serialized, but specify properties can be whitelisted to be serialized. For example, to have theout.global.apiKey
and theout.global.locale
properties serialized you would do the following:There is a chance that this might break existing apps. To revert back to the old behavior on a page-by-page basis you can do the following: