Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jquery to legacy widgets #937

merged 1 commit into from Nov 30, 2017


None yet
3 participants
Copy link

commented Nov 30, 2017

In Marko 4, we removed this.$ and this.ready from the component prototype. However, since many widgets were using these in Marko 3 (and Marko Widgets 6), we added support for marko/jquery and marko/readyto ease the transition.

Enabling these however, patched all components. This PR includes them by default for legacy widgets only.


This comment has been minimized.

Copy link

commented Nov 30, 2017

Coverage Status

Coverage decreased (-0.004%) to 90.576% when pulling 867c656 on jquery-widgets into 413618b on master.


This comment has been minimized.

Copy link

commented Nov 30, 2017

Codecov Report

Merging #937 into master will decrease coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
- Coverage   90.57%   90.57%   -0.01%     
  Files         309      309              
  Lines       11390    11396       +6     
+ Hits        10317    10322       +5     
- Misses       1073     1074       +1
Impacted Files Coverage Δ
...c/components/legacy/defineWidget-legacy-browser.js 95.12% <100%> (+0.25%) ⬆️
src/components/ready.js 53.84% <100%> (ø) ⬆️
src/components/jquery.js 87.09% <80%> (-2.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413618b...867c656. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 8b8fc2c into master Nov 30, 2017

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.004%) to 90.576%
codecov/patch 90.9% of diff hit (target 90.57%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.32% compared to 413618b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@mlrawlings mlrawlings deleted the jquery-widgets branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.