API consistency #21

Closed
Diaoul opened this Issue Apr 27, 2016 · 0 comments

Projects

None yet

1 participant

@Diaoul
Diaoul commented Apr 27, 2016

I've been using rarfile with in-memory streams and it worked great so far. However it seems this API behavior isn't consistent: Diaoul/subliminal#644
In-memory streams don't work with solid archives, I think it's up to rarfile to maintain a consistent API and save the file to a temporary location instead of failing. Of course writing on the filesystem is no easy decision so I suggest to give a configuration option to disable this behavior.

@markokr markokr added a commit that closed this issue May 20, 2016
@markokr Support solid archives from in-memory file object
Those need to be written fully out to tempfile.

Fixes: #21
e51d6aa
@markokr markokr closed this in e51d6aa May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment