Project boilerplate

[huwshimi]

Here is a bunch of project setup stuff. Added setup.py, Makefile, requirements, lint etc.

[mitechie]

we shouldn't need nose and pytest. I think talking with @markramm the thought is to stick to pytest.

[markramm]

I think just using pytest should be enough -- is there something in Nose that we need?

[mitechie]

so this should turn into pytest for test runs and checks.

[markramm]

+1

[bac]

Regarding @mitechie's comment earlier, since deps is a phony (not a real target on the file system with a timestamp), running these tests will cause the deps target to fire every time.

So deps and test-deps should probably have canary files. Something like:

https://pastebin.canonical.com/137717/

The goal is that invoking a makefile target more than once results in nothing being done on subsequent tries. If you run 'make deps' repeatedly now you'll see it invokes pip install each time. And it'll do it every time you try to run tests.

[mitechie]

@markramm @howbazaar can you do a second review of this please? I've asked Huw to look at some project skeleton work to make sure it can be built into a python package and that there's the bones to hang common tools like test running, linting, etc off of.

[mitechie]

check with @bac as I think his trick with working with deps files has been a great way to speed things up. His rework on our own storefront app has implemented this for comparison.

[bac]

This should probably depend on a canary file and on test-requirements.txt. After the install be sure to touch the canary.

[mitechie]

there should also be a releases section that will build the pypi release and we should also generate a wheel as we do on other things.

[mitechie]

let's start with 0.0.1 while in the early stages please.

[mitechie]

Thanks @huwshimi, a few other requests/changes please.

[markramm]

+1 with Rick's changes.

[bac]

Likewise add requirements.txt to this dependency so the deps will get regenerated when that file changes.

[bac]

I don't understand this rule.

[bac]

It's trivial, but it is just weird having the trailing slash in the BIN definition because this now looks funny.

[bac]

This target is not correct as it just just runs 'make test-deps' which is already a dependency.

[bac]

Thanks for this branch @huwshimi. I got kind of carried away looking at the Makefile to ensure I wasn't telling you something dumb. Here is a version that I think is pretty good:

https://pastebin.canonical.com/137718/

With these and @mitechie's suggestions 👍

[huwshimi]

I have made these changes with the exception of "there should also be a releases section that will build the pypi release and we should also generate a wheel as we do on other things." which I am doing in a follow up branch so as to not make this too big.

[bac]

This target should also remove the canaries. Sorry I neglected it.

[bac]

👍 with one small change.

[mitechie]

👍 with @bac's note. Thanks for the update!