Failing test case for Upsert on single column #179

Merged
merged 1 commit into from Apr 16, 2012

Conversation

Projects
None yet
2 participants
@theospears
Contributor

theospears commented Apr 9, 2012

Upsert fails with Ado when you only specify a single column. This patch contains a failing test case. I am undecided between whether this should be fixed by changing the behaviour of Update to allow updating no data, or by changing Upsert to only update when there is data to change, so have not included a fix.

Test for doing upsert with only a single column
It is possible to do an upsert specifying only columns. This fails under
the AdoAdapter because its update assumes that at least one column to
update will be specified.

markrendle added a commit that referenced this pull request Apr 16, 2012

Merge pull request #179 from theospears/master
Failing test case for Upsert on single column

@markrendle markrendle merged commit 365ba94 into markrendle:master Apr 16, 2012

@markrendle

This comment has been minimized.

Show comment
Hide comment
@markrendle

markrendle Apr 16, 2012

Owner

Making test pass now... thanks for the patch.

Owner

markrendle commented Apr 16, 2012

Making test pass now... thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment